Feedback - Refactor Feedback function and update feedback example #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rewrite/clean feedback function Fix/Update Feedback example
zafrirron
changed the title
zafrirron
changed the title
|
Thanks - will do a major version bump when we release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor Feedback Function and Update Example
Refactored and cleaned up the feedback function.
Fixed and updated the feedback example in the examples folder.
Bug Replication: To replicate the bug, use version 4.9 with the feedback
examples. The issue involves polygons sending duplicate feedback.Changes: While fixing the bug, I found the feedback function overly complex and unclear. I’ve commented out the old code and included my comments and questions for clarity.